[Lldb-commits] [PATCH] D58975: Introduce MinidumpEnums.def textual header

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 08:28:27 PST 2019


labath created this revision.
labath added reviewers: zturner, lemo, clayborg, JDevlieghere, teemperor.
Herald added subscribers: fedor.sergeev, dschuff, srhines.
labath added a parent revision: D58973: Move the minidump parser into the Formats module.

The goal of this header is to reduce code duplication in code dealing
with various minidump constants (and having that code break when new
constants are added). It operates the same way as other llvm .def files:

- a user defines an appropriate macro which specifies the set of constants he wants to work with, and what he wants to do with it
- the user includes the .def file, which will invoke the user-defined macro for all known constants in the given set.

Right now, this defines only three constant sets, which correspond to
the ones I needed in followup patches, but others can (and probably
will) be easily added.


https://reviews.llvm.org/D58975

Files:
  include/lldb/Formats/MinidumpEnums.def
  include/lldb/Formats/MinidumpTypes.h
  include/lldb/module.modulemap
  source/Formats/MinidumpParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58975.189334.patch
Type: text/x-patch
Size: 12550 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190305/31b4eceb/attachment-0001.bin>


More information about the lldb-commits mailing list