[Lldb-commits] [PATCH] D58730: Rename Symbols.cpp from Host to Symbols/LocateSymbolFile.{h, cpp}

[Zachary Turner via Phabricator via lldb-commits]

zturner created this revision.
zturner added reviewers: labath, JDevlieghere, jingham.
Herald added subscribers: jdoerfert, MaskRay, arichardson, mgorny, emaste.
Herald added a reviewer: espindola.

After this change, there is only 1 remaining dependency in Host to Target.

While this change might seem like kind of a heavy hammer to solving the dependency problem, it makes more sense even conceptually to be in Symbols.  While some of the specific places to search for symbol files might change depending on the Host, this is not inherently true in the same way that "accessing the file system" or "starting threads" is fundamentally dependent on the Host.

PDBs, for example, recently became a reality on non-Windows platforms, and it's theoretically possible that DSYMs could become a thing on non MacOSX platforms (maybe in a remote debugging scenario).  Other types of symbol files, such as DWO, DWP, etc have never been tied to any Host platform anyway.

So I think this change both makes sense logically, and also improves the layering.


https://reviews.llvm.org/D58730

Files:
  lldb/include/lldb/Host/Symbols.h
  lldb/include/lldb/Symbol/LocateSymbolFile.h
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Core/ModuleList.cpp
  lldb/source/Host/CMakeLists.txt
  lldb/source/Host/common/Symbols.cpp
  lldb/source/Host/macosx/Symbols.cpp
  lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
  lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
  lldb/source/Symbol/CMakeLists.txt
  lldb/source/Symbol/LocateSymbolFile.cpp
  lldb/source/Symbol/LocateSymbolFileMacOSX.cpp
  lldb/unittests/Host/CMakeLists.txt
  lldb/unittests/Host/SymbolsTest.cpp
  lldb/unittests/Symbol/CMakeLists.txt
  lldb/unittests/Symbol/LocateSymbolFileTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58730.188587.patch
Type: text/x-patch
Size: 13957 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190227/fa1d6d0b/attachment-0001.bin>