[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

[Alex Langford via Phabricator via lldb-commits]

xiaobai added a comment.

In D58653#1410964 <https://reviews.llvm.org/D58653#1410964>, @clayborg wrote:

> I agree testing is good. The main things I would like to stay consistent are:
>
> - if any part of a triple isn't specified, we need to be able to tell so that MergeFrom can merge in any unspecified parts (arch, env, os, vendor)
> - if any part of a triple was specified, including "unknown" (since there is no "none" for OS or vendor), then it should remain as is during a MergeFrom
>
>   Target triples are used by many plug-ins to determine if they should load or not. The DynamicLoaderStatic is used for bare board development and relies on someone being able to specify "armv7-unknown-unknown" so that it knows the triple is has a specified "unknown" for OS and vendor. Then it loads all images at the address that they are in the file (load address == file address).


In that case, I plan on doing the following:

- Removing the `IsUnspecifiedUnknown` functions.
- Adding more tests cases so we know if triple parsing changes later in a way that breaks us in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58653/new/

https://reviews.llvm.org/D58653