[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

In D58394#1408117 <https://reviews.llvm.org/D58394#1408117>, @jankratochvil wrote:

> Getting now failure for every run: `LLDB :: ExecControl/StopHook/stop-hook.test`


It is because after this commit (rL354706 <https://reviews.llvm.org/rL354706> = GIT `ff8c7a0947663ce7515f0b8ee52b9d0fe8883bc3`) there was its revert (rL354711 <https://reviews.llvm.org/rL354711> = GIT 0513a24d62e1eef4e8179ced177c3672dab21bce <https://reviews.llvm.org/rG0513a24d62e1eef4e8179ced177c3672dab21bce>) but it did not revert one testcase patch hunk <https://people.redhat.com/jkratoch/D58394-leftover.patch>:

  lldb/lit/ExecControl/StopHook/stop-hook.test
   # CHECK: (lldb) run
  +# CHECK-NEXT: Process {{.*}} launched:
   # CHECK-NEXT: (void *) $0 = 0x
  +# CHECK-NEXT: Process {{.*}} stopped

while on Fedora 29 x86_64 the LLDB output is reversed:

  (lldb) run
  (void *) $0 = 0x0000000000405260
  
  Process 460013 stopped
  * thread #1, name = 'stop-hook.test.', stop reason = breakpoint 1.1
      frame #0: 0x00000000004011c4 stop-hook.test.tmp`b(val=1) at stop-hook.c:29:10
     26  	{
     27  	    int rc = c(val);
     28  	    void *ptr = malloc(1024);
  -> 29  	    if (!ptr)  // Set breakpoint here to test target stop-hook.
     30  	        return -1;
     31  	    else
     32  	        printf("ptr=%p\n", ptr); // We should stop here after stepping.
  
  Process 460013 launched: '.../tools/lldb/lit/ExecControl/StopHook/Output/stop-hook.test.tmp' (x86_64)
  (lldb) thread step-over


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58394/new/

https://reviews.llvm.org/D58394