[Lldb-commits] [PATCH] D51578: 02/03: Contiguous sections (.debug_info+.debug_types) for D54670==D32167 (.debug_types)

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:693-707
+    DataBufferHeap *databufferheap = new DataBufferHeap();
+    DataBufferSP databuffer = DataBufferSP(databufferheap);
+    databufferheap->AppendData(
+        debug_info_data.GetDataStart(),
+        debug_info_data.GetByteSize());
+    m_debug_info_concatenated_types_offset =
+        databufferheap->GetByteSize();
----------------
clayborg wrote:
> So if we have 3GB of .debug_info and 1GB of .debug_types, we are expecting to allocate a heap based buffer and copy all the data into this? This will fail.
replied by: https://reviews.llvm.org/D51578#1400641


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51578/new/

https://reviews.llvm.org/D51578