[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 2 inline comments as done.
teemperor added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/Makefile:3
+USE_LIBCPP := 1
+CXXFLAGS += -std=c++11 -fmodules -glldb -fimplicit-module-maps
+CXX_SOURCES := main.cpp
----------------
aprantl wrote:
> Makefile.rules defines MANDATORY_MODULE_BUILD_FLAGS for this. Can you instead add -fimplicit-module-maps to that variable and use it here?
Well, we would need to add `-glldb` (needed on Linux at least, where this is not default) and `-fimplicit-module-maps` to that flag (and maybe even `-fcxx-modules` on macOS, but I'm not sure about that). Also I'm not sure if we want to have `-gmodules` in the same flag set as the importing of `std` should also work without. What about a separate `MANDATORY_CXXMODULE_BUILD_FLAGS` that we use in all the tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125