[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I haven't gotten a chance to revisit the stop hooks in a long time.  They definitely need some love.

IMO, stop hooks should have the same semantics as breakpoint commands, the first command that causes the target to run should exit the stop hook.  That way you would never get into a situation where you hit another stop hook while handing previous stop's hit.

And we should also add a --continue (maybe also --step & --next) option to the stop hook.  Then we could just disallow step/next/continue in stop hooks.  It is really hard to reason about what to do when handling stops if the contents of the stop hook can restart the target out from under you.  For instance, if you have multiple stop hooks, you have to abort running all the other stop hooks after the first one continues.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58257/new/

https://reviews.llvm.org/D58257