[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 11 06:08:48 PST 2019


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lldb/lit/helper/build.py:296
+        if linker_path is None:
             raise ValueError('Could not find \'{}\''.format(linker_path))
         return linker_path
----------------
labath wrote:
> `linker_path` isn't going to be terribly useful here when it's none. Probably just replace it with `name`.
Indeed, thanks for catching this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58001/new/

https://reviews.llvm.org/D58001





More information about the lldb-commits mailing list