[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 8 01:43:22 PST 2019


labath added a comment.

Could you please write a test for this? You can take a look at unittests/UnwindAssembly/x86/Testx86AssemblyInspectionEngine.cpp for other x86AssemblyInspectionEngine tests.

Also, I'm curious how you found this bug. (i.e. which functionality was broken with the old implementation).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57928/new/

https://reviews.llvm.org/D57928





More information about the lldb-commits mailing list