[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

[Aleksandr Urakov via lldb-commits]

Yes, sure, here it is: https://reviews.llvm.org/D56904

On Tue, Feb 5, 2019 at 7:39 PM Zachary Turner <zturner at google.com> wrote:

> Yes, clang tries to find the visual studio installation, because that is
> how it can find headers and libs.  Can you make a separate patch with the
> changes to build.py and upload that?
>
> On Tue, Feb 5, 2019 at 2:34 AM Aleksandr Urakov via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> aleksandr.urakov added a comment.
>>
>> Thanks for the reply! It seems that after your hint I've figured it out.
>> It's the environment variable `VCINSTALLDIR`. I've added it to the
>> `defaultenv` list of the `_get_visual_studio_environment` function and the
>> test passes now. What do you think about this solution?
>>
>> And do I understand right, it means, that clang-cl needs MSVC
>> installation to work with these types?
>>
>>
>> Repository:
>>   rLLDB LLDB
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D56904/new/
>>
>> https://reviews.llvm.org/D56904
>>
>>
>>
>>

-- 
Aleksandr Urakov
Software Developer
JetBrains
http://www.jetbrains.com
The Drive to Develop
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190206/1211a1e6/attachment.html>