[Lldb-commits] [PATCH] D57402: build: remove custom variables
Stefan Gränitz via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Feb 5 09:29:41 PST 2019
sgraenitz added a comment.
Herald added a project: LLDB.
Hey sorry for the late reply, didn't see this earlier. Personally, I think the move away from the llvm-config approach is good, but I have no strong opinion about the solution.
Pro Zachary's proposal:
- It's good to have fewer ways to do things. The docs describe how to use `LLVM_DIR` to build against LLVM. If that's sufficient LLDB should do the same. https://llvm.org/docs/CMake.html#embedding-llvm-in-your-project
- Clang also deprecated llvm-config, but has no `CLANG_PATH_TO_XY`. It's usually good advice to follow their model. https://github.com/llvm/llvm-project/blob/master/clang/CMakeLists.txt#L17
Pro Alex's code:
- It's a good match for out downstream code https://github.com/apple/swift-lldb/blob/upstream-with-swift/cmake/modules/LLDBStandalone.cmake
- It would allow to have individual build trees for LLVM and Clang right? I don't mind, but someone might?
Has anyone actually tried passing `Clang_DIR`?
CHANGES SINCE LAST ACTION
More information about the lldb-commits