[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

Thanks for adding the ObjC tests!  I had two trivial requests for the test comments to be a little clearer, but even without that this is fine.



================
Comment at: packages/Python/lldbsuite/test/expression_command/context-object-objc/TestContextObjectObjc.py:42-52
+        # Test retrieveing of a property
+        value = obj_val.EvaluateExpression("self.property")
+        self.assertTrue(value.IsValid())
+        self.assertTrue(value.GetError().Success())
+        self.assertEqual(value.GetValueAsSigned(), 2222)
+
+        # Test functions evaluation
----------------
IIUC, these last two are testing that evaluating in the context of an object doesn't effect computations that don't refer to that object.  Is that right?  After all "self.property" doesn't need any help from the objcClass variable to look up the result.  Can you make the comment a little clearer.


================
Comment at: packages/Python/lldbsuite/test/expression_command/context-object-objc/TestContextObjectObjc.py:54
+
+        # Test computation result
+        obj_val = frame.EvaluateExpression("[ObjcClass createNew]")
----------------
This one is testing that when the reference object is an lldb result object, we can still use it correctly.  "Test computation result" is a little terse.  Can you make this a little clearer.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55318/new/

https://reviews.llvm.org/D55318