[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 4 14:22:21 PST 2019
JDevlieghere marked 11 inline comments as done.
JDevlieghere added a comment.
In D56322#1382971 <https://reviews.llvm.org/D56322#1382971>, @labath wrote:
> Thank you. I think this looks much better now.
> It occurred to me that the (de)serializer classes are fully standalone. Since they already have a comprehensive test suite, do you think it would make sense to split them off into a separate patch, which can be committed separately?
Sure, makes sense to me, please see D57714 <https://reviews.llvm.org/D57714>
CHANGES SINCE LAST ACTION
More information about the lldb-commits