[Lldb-commits] [lldb] r353087 - Update stale comment in lang/c/struct_types/main.c

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 4 13:22:16 PST 2019



> On Feb 4, 2019, at 12:33 PM, Jonas Devlieghere via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> Author: jdevlieghere
> Date: Mon Feb  4 12:33:35 2019
> New Revision: 353087
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=353087&view=rev
> Log:
> Update stale comment in lang/c/struct_types/main.c
> 
> rdar://47322760
> 
> Modified:
>    lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c?rev=353087&r1=353086&r2=353087&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c Mon Feb  4 12:33:35 2019
> @@ -26,7 +26,7 @@ int main (int argc, char const *argv[])
>     }; //% self.expect("frame variable pt.padding[0]", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["pt.padding[0] = "])
>        //% self.expect("frame variable pt.padding[1]", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["pt.padding[1] = "])
>        //% self.expect("expression -- (pt.padding[0])", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["(char)", " = "])
> -       //% self.expect("image lookup -t point_tag", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ['padding[]']) # Once rdar://problem/12566646 is fixed, this should display correctly
Was this meant to be checking for something stricter, or was the comment just bogus?

thanks!
adrian
> +       //% self.expect("image lookup -t point_tag", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ['padding[]'])
> 
>     struct {} empty;
>     //% self.expect("frame variable empty", substrs = ["empty = {}"])
> @@ -42,5 +42,5 @@ int main (int argc, char const *argv[])
> 
>     int sum = sum_things(tts); //% self.expect("expression -- &pt == (struct point_tag*)0", substrs = ['false'])
>                                //% self.expect("expression -- sum_things(tts)", substrs = ['9'])
> -    return 0; 
> +    return 0;
> }
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits



More information about the lldb-commits mailing list