[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

Wed Jan 30 17:22:09 PST 2019

thomasanderson added a comment.

In D57466#1377696 <https://reviews.llvm.org/D57466#1377696>, @davide wrote:

> As long as this doesn't break macOS, it's fine. (just run the tests and watch the bots).

Latest revision fixes 2 test failures on Linux.  The first was because ".+" was matching too aggressively, so I changed it to "[[:alnum:]]+".  The second was because libstdc++ printers were getting loaded after libc++, but they need to go before to take precedence.
Can confirm that there's no new test failures with this change on Mac and Linux.  Does the latest revision still lg?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57466/new/

https://reviews.llvm.org/D57466