[Lldb-commits] [lldb] r352397 - [testsuite] Remove trailing characters from command output.

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 28 10:07:28 PST 2019


Author: jdevlieghere
Date: Mon Jan 28 10:07:28 2019
New Revision: 352397

URL: http://llvm.org/viewvc/llvm-project?rev=352397&view=rev
Log:
[testsuite] Remove trailing characters from command output.

When running the test suite on macOS with Python 3 we noticed a
difference in behavior between Python 2 and Python 3 for
seven.get_command_output. The output contained a newline with Python 3,
but not for Python 2. This resulted in an invalid SDK path passed to the
compiler.

Differential revision: https://reviews.llvm.org/D57275

Modified:
    lldb/trunk/packages/Python/lldbsuite/support/seven.py

Modified: lldb/trunk/packages/Python/lldbsuite/support/seven.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/support/seven.py?rev=352397&r1=352396&r2=352397&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/support/seven.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/support/seven.py Mon Jan 28 10:07:28 2019
@@ -15,7 +15,7 @@ else:
                 subprocess.check_output(
                     command,
                     shell=True,
-                    universal_newlines=True))
+                    universal_newlines=True).rstrip())
         except subprocess.CalledProcessError as e:
             return (e.returncode, e.output)
 




More information about the lldb-commits mailing list