[Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Sat Jan 26 18:31:43 PST 2019
Huh, that’s a coincidence. I chose the name because it was “like six”, but
I guess someone else chose it for the same reason
On Sat, Jan 26, 2019 at 2:18 PM Jonas Devlieghere <jonas at devlieghere.com>
> On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>> The idea behind seven is that it’s a place to put stuff that we need for
>> py2/py3 interoperability that doesn’t already exist in six. Yes, maybe
>> there’s only one thing there now, but there could be more over time.
>> At least that was the thinking when I created it.
> When I was looking at this with Davide yesterday, we were under the
> impression that it was an external package (https://pypi.org/project/seven)
> or part thereof. Compatibility with Python 2.5 didn't sound particularly
> important which is why I wanted to remove it. Anyway, now that I know its
> purpose, I'm okay with fixing the newline issue there.
>> It seems like there’s two separate issues here: 1) you need to fix a bug,
>> and 2) you want to propose removing seven. Is it worth doing those two
>> things separately?
>> On Fri, Jan 25, 2019 at 6:00 PM Jonas Devlieghere via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>>> JDevlieghere created this revision.
>>> JDevlieghere added reviewers: davide, zturner, stella.stamenova, labath.
>>> JDevlieghere added a project: LLDB.
>>> Herald added a reviewer: serge-sans-paille.
>>> When running the test suite on macOS with Python 3 we noticed a
>>> difference in behavior between Python 2 and Python 3 for
>>> `seven.get_command_output`. The output contained a newline with Python 3,
>>> but not for Python 2. This resulted in an invalid SDK path passed to the
>>> There were only two actual usages left of this module so I propose to
>>> remove it and have a simple, local implementation for `get_command_output`.
>>> rLLDB LLDB
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits