[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: source/Utility/FileCollector.cpp:27-33
+  // Change path to all upper case and ask for its real path, if the latter
+  // exists and is equal to path, it's not case sensitive. Default to case
+  // sensitive in the absence of real_path, since this is the YAMLVFSWriter
+  // default.
+  upper_dest = path.upper();
+  if (sys::fs::real_path(upper_dest, real_dest) && path.equals(real_dest))
+    return false;
----------------
davide wrote:
> should this be a function in FS to check the case-sensitiveness?
As Host depends on Utility, we cannot depend on the filesystem class here.


================
Comment at: source/Utility/FileCollector.cpp:84-87
+  // Canonicalize the source path by removing "..", "." components.
+  SmallString<256> virtual_path = absolute_src;
+  sys::path::remove_dots(virtual_path, /*remove_dot_dot=*/true);
+
----------------
davide wrote:
> Ditto (I thought there was one to canonicalize the source path?)
See previous answer. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54617/new/

https://reviews.llvm.org/D54617