[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:1-8
+//===-- ArchitectureArc.cpp -------------------------------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
----------------
Does this file need to exist anymore? If not remove it. If so, fill in at least one virtual function that is needed.


================
Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.h:18-22
+enum {
+  reduced_register_file = 1u << 0,
+  big_endian = 1u << 1,
+  address_size_32 = 1u << 2
+};
----------------
Would this be better as a public enum inside of the ArchitectureArc class named Flags?

```
class ArchitectureArc: public Architecture {
  enum Flags {
    reduced_register_file = 1u << 0,
    big_endian = 1u << 1,
    address_size_32 = 1u << 2
  };
};
```
There is also a definition that marks a enum as a bitfield.


================
Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.h:34
+
+  void OverrideStopInfo(Thread &thread) const override {}
+
----------------
Are we missing this? Any reason for this to exist? If this function need to doesn't exist then this ArchitectureArc class doesn't need to exist and can be removed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718