[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin
Tatyana Krasnukha via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sat Jan 19 07:13:32 PST 2019
tatyana-krasnukha added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1222-1223
+ if (!arch_plugin->SetFeatures(reg_reader) && log)
+ log->PutCString("Failed to set architecture features");
> All this work should be done in this function then use arch_plug->GetFlags().Set(mask);
Then I'll return to polluting this code with ARC-specific flags and registers.
I would avoid passing this monstrous `reg_reader` to the Architecture if I could pass RegisterContext there. However, RegisterContext doesn't exist yet at this step. And there is no entity that can read registers without a context.
CHANGES SINCE LAST ACTION
More information about the lldb-commits