[Lldb-commits] [PATCH] D56844: Breakpad: Extract parsing code into a separate file
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jan 17 04:06:28 PST 2019
labath created this revision.
labath added reviewers: clayborg, lemo, zturner.
Herald added subscribers: fedor.sergeev, mgorny.
This centralizes parsing of breakpad records, which was previously
spread out over ObjectFileBreakpad and SymbolFileBreakpad.
For each record type X there is a separate breakpad::XRecord class, and
an associated parse function. The classes just store the information in
the breakpad records in a more accessible form. It is up to the users to
determine what to do with that data.
This separation also made it possible to write some targeted tests for
the parsing code, which was previously unaccessible, so I write a couple
of those too.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 26859 bytes
Desc: not available
More information about the lldb-commits