[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 15 11:54:54 PST 2019

zturner added a comment.

In D56230#1358328 <https://reviews.llvm.org/D56230#1358328>, @labath wrote:

> In D56230#1358269 <https://reviews.llvm.org/D56230#1358269>, @Hui wrote:
> > > - drop the `if (m_entries[i].quote)` branch. You don't need it here, and I don't believe it will be correct anyway, because all it will do is cause `llvm::sys::flattenWindowsCommandLine` to add one more quote level around that and escape the quotes added by yourself
> >
> > The quote char might be specified through Args::AppendArgument at user's will.
> Yes, but do you know what the user meant when he set it? I don't, but I'm pretty sure he did not mean it to be passed verbatim to the launched process. It certainly isn't what will happen on posix systems as there we just ignore it. Maybe nobody knows, which is why nobody sets it? I think it would be best to be consistent with posix systems, and ignore it here too (at least until we have a good reason to do otherwise).

I've always disliked this argument and hoped that someday someone would remove it entirely.  My recollection (which may be wrong) is that the only actual use of it is so that if someone types a command, and we later need to print the command back, we will print it with the same quote char.  It almost seems like we could just delete the argument and use a standardized quote char when flattening a command string.



More information about the lldb-commits mailing list