[Lldb-commits] [PATCH] D56688: Make CompilerType::getBitSize() / getByteSize() return an optional result. (NFC)
Davide Italiano via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 15 09:37:37 PST 2019
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I hit an incarnation of this problem, and I was able to get away with a localized fix in:
[lldb] r344982 - [ValueObject] Stop assuming types are non-zero sized.
Of course, your approach is principled and it's IMHO clearly the right way forward.
I didn't check every single callsite, as the patch is mechanical enough, but the general idea looks good to me.
CHANGES SINCE LAST ACTION
More information about the lldb-commits