[Lldb-commits] [PATCH] D56458: Fix unused private field warning.

[David Blaikie via lldb-commits]

Might be better to only define the variable if HAVE_LIBCOMPRESSION is
defined?

On Wed, Jan 9, 2019 at 8:58 AM Raphael Isemann via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> This revision was not accepted when it landed; it landed in state "Needs
> Review".
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL350675: Fix unused private field warning. (authored by
> teemperor, committed by ).
> Herald added a subscriber: llvm-commits.
>
> Changed prior to commit:
>   https://reviews.llvm.org/D56458?vs=180748&id=180750#toc
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D56458/new/
>
> https://reviews.llvm.org/D56458
>
> Files:
>   lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
>
>
> Index:
> lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
> ===================================================================
> --- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
> +++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
> @@ -69,8 +69,9 @@
>        m_echo_number(0), m_supports_qEcho(eLazyBoolCalculate),
> m_history(512),
>        m_send_acks(true), m_compression_type(CompressionType::None),
>        m_listen_url(), m_decompression_scratch_type(CompressionType::None),
> -      m_decompression_scratch(nullptr)
> -{
> +      m_decompression_scratch(nullptr) {
> +  // Unused unless HAVE_LIBCOMPRESSION is defined.
> +  (void)m_decompression_scratch_type;
>  }
>
>  //----------------------------------------------------------------------
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190114/7bdcc352/attachment.html>