[Lldb-commits] [PATCH] D56609: [CMake] Remove dead code and outdated comments

Fri Jan 11 09:50:35 PST 2019

sgraenitz marked 2 inline comments as done.
sgraenitz added a comment.

Simple cleanup parts of the previous reviews D56400 <https://reviews.llvm.org/D56400> and D56440 <https://reviews.llvm.org/D56440>

================
Comment at: lit/CMakeLists.txt:21
-endif ()
-
 get_property(LLDB_DOTEST_ARGS GLOBAL PROPERTY LLDB_DOTEST_ARGS_PROPERTY)
----------------
This only changes the value of `LLDB_TEST_C/CXX_COMPILER` in the scope this file. It is unused since https://reviews.llvm.org/rC347216#change-H2HV4zA8ol05 removed their usage from `lit/lit.site.cfg.py.in` (which gets configured below). Before this change the local value was passed to the config file like this:

```
config.cc = "@LLDB_TEST_C_COMPILER@"
config.cxx = "@LLDB_TEST_CXX_COMPILER@"
```

They seem to be inferred via `LLDB_LIT_TOOLS_DIR` now.

================
Comment at: lit/CMakeLists.txt:51
-endif(BUILD_SHARED_LIBS)
-
 # the value is not canonicalized within LLVM
----------------
`LLDB_HAVE_LLD` was only used between r331447 and r347216.
`ENABLE_SHARED` was only used between r232205 and r232227.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56609/new/

https://reviews.llvm.org/D56609