[Lldb-commits] [PATCH] D56602: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: zturner, clayborg, jingham, davide, teemperor.
Herald added subscribers: mgorny, emaste.

These classes describe the details of the process we are about to
launch, and so they are naturally used by the launching code in the Host
module. Previously they were present in Target because that is the most
important (but by far not the only) user of the launching code.

Since the launching code has other customers, must of which do not care
about Targets, it makes sense to move these classes to the Host layer,
next to the launching code.

This move reduces the number of times that Target is included from host
to 8 (it used to be 14).


https://reviews.llvm.org/D56602

Files:
  include/lldb/Host/FileAction.h
  include/lldb/Host/ProcessInfo.h
  include/lldb/Host/ProcessLaunchInfo.h
  include/lldb/Target/FileAction.h
  include/lldb/Target/Process.h
  include/lldb/Target/ProcessInfo.h
  include/lldb/Target/ProcessLaunchInfo.h
  include/lldb/Target/Target.h
  include/lldb/module.modulemap
  source/API/SBLaunchInfo.cpp
  source/Host/CMakeLists.txt
  source/Host/common/FileAction.cpp
  source/Host/common/Host.cpp
  source/Host/common/MonitoringProcessLauncher.cpp
  source/Host/common/ProcessInfo.cpp
  source/Host/common/ProcessLaunchInfo.cpp
  source/Host/macosx/objcxx/Host.mm
  source/Host/posix/ProcessLauncherPosixFork.cpp
  source/Host/windows/ProcessLauncherWindows.cpp
  source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
  source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  source/Target/CMakeLists.txt
  source/Target/FileAction.cpp
  source/Target/ProcessInfo.cpp
  source/Target/ProcessLaunchInfo.cpp
  unittests/Host/CMakeLists.txt
  unittests/Host/FileActionTest.cpp
  unittests/Host/ProcessInfoTest.cpp
  unittests/Host/ProcessLaunchInfoTest.cpp
  unittests/tools/lldb-server/tests/TestClient.cpp
  unittests/tools/lldb-server/tests/TestClient.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56602.181278.patch
Type: text/x-patch
Size: 21960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190111/fd91790a/attachment-0001.bin>