[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 8 14:32:25 PST 2019


amccarth added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:318
+
+  TypeSystem *type_system = GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus);
+  if (!type_system)
----------------
Is it appropriate to hard code that language type here?  I realize we don't have good PDB support of many other languages, but what about C?  Or various versions of C++?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56418/new/

https://reviews.llvm.org/D56418





More information about the lldb-commits mailing list