[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz created this revision.
sgraenitz added reviewers: labath, zturner, ted, JDevlieghere, stella.stamenova.
Herald added a subscriber: mgorny.

Following up from D56400 <https://reviews.llvm.org/D56400>:

- add `LLDB_TEST_COMPILER` setting, while still supporting `LLDB_TEST_C/CXX_COMPILER`
- remove `LLDB_TEST_USE_CUSTOM_C/CXX_COMPILER`: overriding `LLDB_TEST_COMPILER` alone is sufficient
- use `LLDB_TEST_COMPILER_IS_DEFAULT` to determine whether or not to replace configuration names
- update documentation to reflect changes

As we import targets like `clang` and `dsymutil` anyway, we might use generator expressions to fetch paths of the required tools.
The problem is not that generator expressions don't work in the multi-config case. We just need a generation-time step for each lit.site.cfg, something like this:
https://github.com/llvm-mirror/lldb/blob/5febeff671748655213b74bbd71e7d2efc1a9efe/test/CMakeLists.txt#L169


https://reviews.llvm.org/D56440

Files:
  CMakeLists.txt
  lit/CMakeLists.txt
  test/CMakeLists.txt
  www/build.html
  www/test.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56440.180659.patch
Type: text/x-patch
Size: 7063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190108/fedb6a41/attachment-0001.bin>