[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 7 11:09:43 PST 2019


sgraenitz marked an inline comment as done.
sgraenitz added inline comments.


================
Comment at: CMakeLists.txt:47
+  # FIXME: With generator expressions we could simply query the output paths for each target,
+  # but for this LLDB_DOTEST_ARGS must always have a generator step.
 
----------------
I think these would be all good to fix, but I am not sure I can do it now. Should we keep remaining ones as FIXME?
Currently investigating the `LLVM_BINARY_DIR` issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56400/new/

https://reviews.llvm.org/D56400





More information about the lldb-commits mailing list