[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jan 3 02:22:46 PST 2019
labath added a comment.
I would definitely encourage using something better than the file checksum as UUID, if at all possible.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:139
+ uuid =
I think this should be `fromData`. The `Optional` is there to give special meaning to an all-zero checksum, but you don't need that here. Just because the md5 checksum comes out as all-zero, it doesn't mean it is not valid.
PS: I am responsible for the existence of this function, so I am to blame for any confusion. If you have any idea, how to make this api more clear, I'd like to hear it.
CHANGES SINCE LAST ACTION
More information about the lldb-commits