[Lldb-commits] [PATCH] D56170: RangeMap.h: merge RangeDataArray and RangeDataVector
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jan 2 02:02:10 PST 2019
labath marked an inline comment as done.
labath added inline comments.
Comment at: unittests/Core/RangeMapTest.cpp:52-54
+ // However, this does not always succeed.
+ // TODO: This should probably return the range (0, 40) as well.
+ EXPECT_THAT(Map.FindEntryThatContains(35), nullptr);
> I think this is a bug in the implementation.
I agree. I think this can be fixed if we change the while loop in `FindEntryThatContains` to loop until the current range start address goes below the lookup address. If that's the behavior we want from this function, that is.
CHANGES SINCE LAST ACTION
More information about the lldb-commits