[Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

[Pavel Labath via lldb-commits]

BTW, the flakiness decorators have no effect when using lit as the test 
runner. They relied on passing a message from the test to the test 
framework, which caused the latter to re-run the test. Of course, lit 
has no idea what to do with these messages.

On 30/12/2018 17:24, Davide Italiano via lldb-commits wrote:
> No problem, thanks!
> 
> On Sun, Dec 30, 2018 at 5:11 PM Jonas Devlieghere <jonas at devlieghere.com> wrote:
>>
>>
>>
>> On Sun, Dec 30, 2018 at 05:33 Davide Italiano <dccitaliano at gmail.com> wrote:
>>>
>>> Nice, thanks!
>>> There is a typo in the commit message, I assume?
>>
>>
>> Correct, I made a typo in the PR and then mindlessly copied the name of the test.
>>>
>>>
>>>
>>> On Sun, Dec 30, 2018 at 7:13 AM Jonas Devlieghere via lldb-commits
>>> <lldb-commits at lists.llvm.org> wrote:
>>>>
>>>> Author: jdevlieghere
>>>> Date: Sat Dec 29 22:10:03 2018
>>>> New Revision: 350160
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=350160&view=rev
>>>> Log:
>>>> [test] Remove flakiness decorator from TestObjCDynamicSBType
>>>>
>>>> The quoted bug report (llvm.org/PR20270) was closed in 2014.
>>>>
>>>> Modified:
>>>>      lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py
>>>>
>>>> Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py
>>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py?rev=350160&r1=350159&r2=350160&view=diff
>>>> ==============================================================================
>>>> --- lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py (original)
>>>> +++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py Sat Dec 29 22:10:03 2018
>>>> @@ -6,7 +6,6 @@ from __future__ import print_function
>>>>
>>>>
>>>>   import lldb
>>>> -from lldbsuite.test.decorators import *
>>>>   from lldbsuite.test.lldbtest import *
>>>>   from lldbsuite.test import lldbutil
>>>>
>>>> @@ -24,7 +23,6 @@ class ExprCommandCallStopContinueTestCas
>>>>               '// Please test these expressions while stopped at this line:')
>>>>           self.func_line = line_number('main.cpp', '{5, "five"}')
>>>>
>>>> -    @expectedFlakeyDarwin("llvm.org/pr20274")
>>>>       def test(self):
>>>>           """Test gathering result from interrupted function call."""
>>>>           self.build()
>>>>
>>>>
>>>> _______________________________________________
>>>> lldb-commits mailing list
>>>> lldb-commits at lists.llvm.org
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>
>> --
>> Sent from my iPhone
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>