[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

George Rimar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 21 10:53:40 PST 2018


grimar created this revision.
grimar added reviewers: LLDB, clayborg.

This is https://bugs.llvm.org/show_bug.cgi?id=40112,

Currently, lldb crashes after pressing the up arrow key when listing the history for expressions.

The patch fixes the mistype that was a reason.


https://reviews.llvm.org/D56014

Files:
  source/Host/common/Editline.cpp


Index: source/Host/common/Editline.cpp
===================================================================
--- source/Host/common/Editline.cpp
+++ source/Host/common/Editline.cpp
@@ -443,7 +443,7 @@
     m_live_history_lines = m_input_lines;
     m_in_history = true;
   } else {
-    if (history_w(pHistory, &history_event, earlier ? H_NEXT : H_PREV) == -1) {
+    if (history_w(pHistory, &history_event, earlier ? H_PREV : H_NEXT) == -1) {
       // Can't move earlier than the earliest entry
       if (earlier)
         return CC_ERROR;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56014.179313.patch
Type: text/x-patch
Size: 541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181221/8530cad1/attachment-0001.bin>


More information about the lldb-commits mailing list