[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

Fri Dec 21 02:27:00 PST 2018

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.

================
Comment at: source/Core/ModuleList.cpp:72
      {},
      "Control the use of external tools or libraries to locate symbol files. "
+     "Directories listed in target.debug-file-search-paths and directory of "
----------------
My main issue here was with the "tools or libraries" part of this description -- we're not using any special tools or libraries when looking in /usr/lib/debug.

Maybe just say that this is controls whether we use "external sources" when searching for symbols. The rest of the description is fine (though I would just drop the ifdefs and print everything everywhere).

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55859/new/

https://reviews.llvm.org/D55859