[Lldb-commits] [lldb] r349668 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)
Stella Stamenova via lldb-commits
lldb-commits at lists.llvm.org
Wed Dec 19 11:10:25 PST 2018
Author: stella.stamenova
Date: Wed Dec 19 11:10:25 2018
New Revision: 349668
URL: http://llvm.org/viewvc/llvm-project?rev=349668&view=rev
Log:
[lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)
This is a set of tests that were all marked as failing becuse of pr21765. The bug is not fixed (as in more of the tests that were marked this way are failing), but this set is passing. It is possible that some of them are false positives, but there's a large number of unexpectedly passing tests on Windows, so I am doing a bulk un-xfail to get the buildbot to green.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestAllowJIT.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/pr35310/TestExprsBug35310.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py
lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py
lldb/trunk/packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py Wed Dec 19 11:10:25 2018
@@ -41,7 +41,6 @@ class ExprCharTestCase(TestBase):
self.assertTrue(value.GetError().Success())
self.assertEqual(value.GetValueAsSigned(0), 3)
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_default_char(self):
self.do_test()
@@ -52,7 +51,6 @@ class ExprCharTestCase(TestBase):
"powerpc64le",
"s390x"],
bugnumber="llvm.org/pr23069")
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_signed_char(self):
self.do_test(dictionary={'CFLAGS_EXTRAS': '-fsigned-char'})
@@ -64,7 +62,6 @@ class ExprCharTestCase(TestBase):
'armv7',
'armv7k'],
bugnumber="llvm.org/pr23069, <rdar://problem/28721938>")
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
@expectedFailureAll(triple='mips*', bugnumber="llvm.org/pr23069")
def test_unsigned_char(self):
self.do_test(dictionary={'CFLAGS_EXTRAS': '-funsigned-char'})
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestAllowJIT.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestAllowJIT.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestAllowJIT.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestAllowJIT.py Wed Dec 19 11:10:25 2018
@@ -22,22 +22,18 @@ class TestAllowJIT(TestBase):
# each debug info format.
NO_DEBUG_INFO_TESTCASE = True
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_allow_jit_expr_command(self):
"""Test the --allow-jit command line flag"""
self.build()
self.main_source_file = lldb.SBFileSpec("main.c")
self.expr_cmd_test()
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_allow_jit_options(self):
"""Test the SetAllowJIT SBExpressionOption setting"""
self.build()
self.main_source_file = lldb.SBFileSpec("main.c")
self.expr_options_test()
-
-
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@@ -62,7 +58,7 @@ class TestAllowJIT(TestBase):
"Set a breakpoint here", self.main_source_file)
frame = thread.GetFrameAtIndex(0)
-
+
# First make sure we can call the function with the default option set.
options = lldb.SBExpressionOptions()
# Check that the default is to allow JIT:
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py Wed Dec 19 11:10:25 2018
@@ -17,7 +17,6 @@ class NestedPersistentTypesTestCase(Test
mydir = TestBase.compute_mydir(__file__)
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_persistent_types(self):
"""Test that nested persistent types work."""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py Wed Dec 19 11:10:25 2018
@@ -17,7 +17,6 @@ class PersistenttypesTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_persistent_types(self):
"""Test that lldb persistent types works correctly."""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/pr35310/TestExprsBug35310.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/pr35310/TestExprsBug35310.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/pr35310/TestExprsBug35310.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/pr35310/TestExprsBug35310.py Wed Dec 19 11:10:25 2018
@@ -16,7 +16,6 @@ class ExprBug35310(TestBase):
self.main_source = "main.cpp"
self.main_source_spec = lldb.SBFileSpec(self.main_source)
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_issue35310(self):
"""Test invoking functions with non-standard linkage names.
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py Wed Dec 19 11:10:25 2018
@@ -18,7 +18,6 @@ class Radar9531204TestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
# rdar://problem/9531204
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_expr_commands(self):
"""The evaluating printf(...) after break stop and then up a stack frame."""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py Wed Dec 19 11:10:25 2018
@@ -24,7 +24,6 @@ class Radar9673644TestCase(TestBase):
self.main_source = "main.c"
self.line = line_number(self.main_source, '// Set breakpoint here.')
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_expr_commands(self):
"""The following expression commands should just work."""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py Wed Dec 19 11:10:25 2018
@@ -102,7 +102,6 @@ class BasicExprCommandsTestCase(TestBase
# (const char *) $8 = 0x... "/Volumes/data/lldb/svn/trunk/test/expression_command/test/a.out"
@add_test_categories(['pyapi'])
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_evaluate_expression_python(self):
"""Test SBFrame.EvaluateExpression() API for evaluating an expression."""
self.build()
@@ -203,7 +202,6 @@ class BasicExprCommandsTestCase(TestBase
# rdar://problem/8686536
# CommandInterpreter::HandleCommand is stripping \'s from input for
# WantsRawCommand commands
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_expr_commands_can_handle_quotes(self):
"""Throw some expression commands with quotes at lldb."""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py Wed Dec 19 11:10:25 2018
@@ -11,7 +11,6 @@ class CStringsTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_with_run_command(self):
"""Tests that C strings work as expected in expressions"""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py Wed Dec 19 11:10:25 2018
@@ -8,7 +8,6 @@ class TestCppChainedCalls(TestBase):
mydir = TestBase.compute_mydir(__file__)
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_with_run_command(self):
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py Wed Dec 19 11:10:25 2018
@@ -49,7 +49,6 @@ class TestCppGlobalOperators(TestBase):
return thread.GetSelectedFrame()
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_equals_operator(self):
frame = self.prepare_executable_and_get_frame()
@@ -87,7 +86,6 @@ class TestCppGlobalOperators(TestBase):
self.assertTrue(got_type.IsPointerType())
self.assertEqual(got_type.GetPointeeType().GetName(), "Struct")
- @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
def test_operator_new(self):
frame = self.prepare_executable_and_get_frame()
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py?rev=349668&r1=349667&r2=349668&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py Wed Dec 19 11:10:25 2018
@@ -16,7 +16,6 @@ class CPPStaticMethodsTestCase(TestBase)
TestBase.setUp(self)
self.line = line_number('main.cpp', '// Break at this line')
- @expectedFailureAll(oslist=["windows"])
def test_with_run_command(self):
"""Test that static methods are properly distinguished from regular methods"""
self.build()
More information about the lldb-commits
mailing list