[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

Wed Dec 19 09:25:01 PST 2018

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

One quick change required to avoid STL in public headers.

================
Comment at: include/lldb/lldb-forward.h:16
 #include "lldb/Utility/SharingPtr.h"
+#include <vector>

----------------
Remove due to this header being part of the public API.

================
Comment at: include/lldb/lldb-forward.h:136
+class MemoryRegionInfo;
+typedef std::vector<lldb_private::MemoryRegionInfo> MemoryRegionInfos;
 class Module;
----------------
After thinking about this a bit, we shouldn't put any STL stuff in headers that are part of the public API as we never want to expose any STL through our API. Can probably move this into MemoryRegionInfo.h, or just use "std::vector<lldb_private::MemoryRegionInfo>" everywhere as long as it is in lldb_private or the global namespace (we only export "lldb::*").

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55472/new/

https://reviews.llvm.org/D55472