[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 18 09:59:50 PST 2018


JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, sgraenitz, aprantl.
JDevlieghere added a project: LLDB.
Herald added a subscriber: mgorny.
Herald added a reviewer: EricWF.

As discussed on IRC this morning, when building an in-tree clang for testing we have to have libcxx and libcxxabi checked out. This is a common pitfall that manifests that is non-obvious and manifests itself only after building when running the test suite.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D55837

Files:
  CMakeLists.txt


Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -157,6 +157,8 @@
 
   if(TARGET clang)
     list(APPEND LLDB_TEST_DEPS clang)
+    list(APPEND LLDB_TEST_DEPS cxx)
+    list(APPEND LLDB_TEST_DEPS cxxabi)
   endif()
 
   if(TARGET dsymutil)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55837.178717.patch
Type: text/x-patch
Size: 322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181218/96b525fe/attachment.bin>


More information about the lldb-commits mailing list