[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 11 09:51:15 PST 2018
clayborg added a comment.
In D55522#1326955 <https://reviews.llvm.org/D55522#1326955>, @labath wrote:
> It just occurred to me that we have another copy of /proc/<pid>/maps -> MemoryRegionInfo conversion code. It lives in NativeProcessLinux.cpp (ParseMemoryRegionInfoFromProcMapsLine). It would be nice to extract this parser into a some place (`Plugins/Process/Utility` ?), where it can be shared by the two process plugins. As a bonus, that should make it easy to write unit tests for that function.
Nice! I should have looked around. I will move it to Plugins/Process/Utility as suggested
CHANGES SINCE LAST ACTION
More information about the lldb-commits