[Lldb-commits] [PATCH] D55522: Cache memory regions and use the linux maps as the source of the information if available.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 10 10:09:06 PST 2018


clayborg created this revision.
clayborg added reviewers: labath, markmentovai, zturner, tatyana-krasnukha.
Herald added a subscriber: mgrang.

Breakpad creates minidump files that sometimes have:

- linux maps textual content
- no MemoryInfoList

Right now unless the file has a MemoryInfoList we get no region information.

This patch:

- reads and caches the memory region info one time and sorts it for easy subsequent access
- get the region info from the best source in this order:
  - linux maps info (if available)
  - MemoryInfoList (if available)
  - MemoryList or Memory64List
- returns memory region info for the gaps between regions (before the first and after the last)

This patch is a different patch that would replace: https://reviews.llvm.org/D55472

If we decide to go with this patch, then I will add tests.


https://reviews.llvm.org/D55522

Files:
  source/Plugins/Process/minidump/MinidumpParser.cpp
  source/Plugins/Process/minidump/MinidumpParser.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55522.177550.patch
Type: text/x-patch
Size: 11246 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181210/746d488a/attachment.bin>


More information about the lldb-commits mailing list