[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 10 10:01:55 PST 2018
zturner added inline comments.
Comment at: include/lldb/API/SBMemoryRegionInfoList.h:31
- bool GetMemoryRegionAtIndex(uint32_t idx, SBMemoryRegionInfo ®ion_info);
+ void Reserve(size_t capacity);
> This you can add, but std::vector implementations are quite efficient and I doubt this is really needed?
std::vector is as efficient as it can be without additional hints from the user, but reserve is a very useful optimization in general.
CHANGES SINCE LAST ACTION
More information about the lldb-commits