[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 10 04:18:40 PST 2018


sgraenitz added a comment.

Sorry for editing this again, but D55328 <https://reviews.llvm.org/D55328> brought up an important change request (see https://reviews.llvm.org/D55328#anchor-1322655) and I only realized this side-effect afterwards: adding LLDB to a LLVM build tree (all with default configurations), would have caused all binaries to be signed with the lldb_codesign identity. This is clearly not intended. The modified summary now outlines the identity handling in more detail. @labath thanks for bringing up your concerns, I did the change here and will adjust the other review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55013/new/

https://reviews.llvm.org/D55013





More information about the lldb-commits mailing list