[Lldb-commits] [lldb] r348711 - Revert a hunk that shouldn't have been included in the last commit.

Frederic Riss via lldb-commits lldb-commits at lists.llvm.org
Sat Dec 8 18:38:04 PST 2018


Author: friss
Date: Sat Dec  8 18:38:04 2018
New Revision: 348711

URL: http://llvm.org/viewvc/llvm-project?rev=348711&view=rev
Log:
Revert a hunk that shouldn't have been included in the last commit.

I've seen this line trigger UB, but that's obviously not the correct fix...

Modified:
    lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp?rev=348711&r1=348710&r2=348711&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp Sat Dec  8 18:38:04 2018
@@ -90,7 +90,7 @@ static inline uint64_t
 AddWithCarry(uint32_t N, uint64_t x, uint64_t y, bit carry_in,
              EmulateInstructionARM64::ProcState &proc_state) {
   uint64_t unsigned_sum = UInt(x) + UInt(y) + UInt(carry_in);
-  int64_t signed_sum = 0;//SInt(x) + SInt(y) + UInt(carry_in);
+  int64_t signed_sum = SInt(x) + SInt(y) + UInt(carry_in);
   uint64_t result = unsigned_sum;
   if (N < 64)
     result = Bits64(result, N - 1, 0);




More information about the lldb-commits mailing list