[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz marked an inline comment as done.
sgraenitz added inline comments.


================
Comment at: cmake/modules/LLDBConfig.cmake:64
+  set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE)
+endif()
+
----------------
sgraenitz wrote:
> @labath Could this be a way to phase out LLDB_CODESIGN_IDENTITY and move to the LLVM one?
> 
> * An **explicitly set** LLDB value takes precedence
> * Warn if a non-empty LLVM value is overwritten
> * Default to lldb_codesign if none is set explicitly
Not sure if it is too intrusive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55328/new/

https://reviews.llvm.org/D55328