[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, zturner, lemo, markmentovai, amccarth.

This patch allows ObjectFileBreakpad to parse the contents of Breakpad
files into sections. This sounds slightly odd at first, but in essence
its not too different from how other object files handle things. For
example in elf files, the symtab section consists of a number of
"records", where each record represents a single symbol. The same is
true for breakpad's PUBLIC section, except in this case, the records will be
textual instead of binary.

To keep sections contiguous, I create a new section every time record
type changes. Normally, the breakpad processor will group all records of
the same type in one block, but the format allows them to be intermixed,
so in general, the "object file" may contain multiple sections with the
same record type.


https://reviews.llvm.org/D55434

Files:
  include/lldb/Utility/DataExtractor.h
  lit/Modules/Breakpad/Inputs/discontiguous-sections.syms
  lit/Modules/Breakpad/Inputs/sections-trailing-func.syms
  lit/Modules/Breakpad/Inputs/sections.syms
  lit/Modules/Breakpad/discontiguous-sections.test
  lit/Modules/Breakpad/sections-trailing-func.test
  lit/Modules/Breakpad/sections.test
  source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55434.177209.patch
Type: text/x-patch
Size: 10866 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181207/00266821/attachment-0001.bin>