[Lldb-commits] [lldb] r348502 - Add another ArchSpec unit test.

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 6 09:11:45 PST 2018


Author: adrian
Date: Thu Dec  6 09:11:45 2018
New Revision: 348502

URL: http://llvm.org/viewvc/llvm-project?rev=348502&view=rev
Log:
Add another ArchSpec unit test.

Modified:
    lldb/trunk/unittests/Utility/ArchSpecTest.cpp

Modified: lldb/trunk/unittests/Utility/ArchSpecTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/ArchSpecTest.cpp?rev=348502&r1=348501&r2=348502&view=diff
==============================================================================
--- lldb/trunk/unittests/Utility/ArchSpecTest.cpp (original)
+++ lldb/trunk/unittests/Utility/ArchSpecTest.cpp Thu Dec  6 09:11:45 2018
@@ -210,7 +210,7 @@ TEST(ArchSpecTest, Compatibility) {
     ArchSpec B("arm64-apple-ios");
     ASSERT_FALSE(A.IsExactMatch(B));
     // FIXME: This looks unintuitive and we should investigate whether
-    // thi is the desired behavior.
+    // this is the desired behavior.
     ASSERT_FALSE(A.IsCompatibleMatch(B));
   }
   {
@@ -220,4 +220,11 @@ TEST(ArchSpecTest, Compatibility) {
     // FIXME: See above, though the extra environment complicates things.
     ASSERT_FALSE(A.IsCompatibleMatch(B));
   }
+  {
+    ArchSpec A("x86_64");
+    ArchSpec B("x86_64-apple-macosx10.14");
+    // FIXME: The exact match also looks unintuitive.
+    ASSERT_TRUE(A.IsExactMatch(B));
+    ASSERT_TRUE(A.IsCompatibleMatch(B));
+  }
 }




More information about the lldb-commits mailing list