[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 5 14:36:45 PST 2018


jingham added a comment.

This looks good.  Can you add two more tests:

1. Can you add a step to your tests that shows fetching the current exception object from a thread that doesn't have an exception does the right thing (i.e. nothing).
2. Since C++ and ObjC exceptions use the same mechanism can you test that at abort after an uncaught C++ exception, getting the exception for the thread also does nothing (i.e. doesn't crash or produce some mangled object).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44072/new/

https://reviews.llvm.org/D44072





More information about the lldb-commits mailing list