[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Wed Dec 5 12:54:46 PST 2018

I think with all the tests running in parallel we should err on the side of having unique names for everything automatically generated.

From: Aleksandr Urakov <aleksandr.urakov at jetbrains.com>
Sent: Wednesday, December 5, 2018 12:48 PM
To: Zachary Turner <zturner at google.com>
Cc: reviews+D54942+public+2603ca548f36d222 at reviews.llvm.org; Stella Stamenova <stilis at microsoft.com>; llvm-commits at lists.llvm.org; abidh.haq at gmail.com; teemperor at gmail.com; lldb-commits at lists.llvm.org; sanimir at subpath.org; chirag at raincode.com; b.gianfo at gmail.com
Subject: Re: [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

With such solution there would be even no need to change the current commit. But I'm not sure that it's trivial to do - the output file name may contain path with directories. May be we can replace slashes with underscores in the output file path and concatenate it with the object file name? Or even replace slashes in the source file path and concatenate it with the output file path - so object files will be located in the same place as the output file.
Am Mi., 5. Dez. 2018, 23:30 hat Zachary Turner <zturner at google.com<mailto:zturner at google.com>> geschrieben:
It is not possible to specify object file name in compile and link mode. But perhaps we can just change the default object file name to include something from the output file as well
On Wed, Dec 5, 2018 at 12:26 PM Aleksandr Urakov via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
aleksandr.urakov added a subscriber: zturner.
aleksandr.urakov added a comment.

The similar problem with `typedefs.test` is here: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1940/steps/test/logs/stdio<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8014%2Fbuilders%2Flldb-x64-windows-ninja%2Fbuilds%2F1940%2Fsteps%2Ftest%2Flogs%2Fstdio&data=02%7C01%7Cstilis%40microsoft.com%7C91af7eec00544628293a08d65af2edaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636796396749066675&sdata=qk20%2B1v4xKGNNWic0O8p5ybgNJF5jzurS%2BW3YXxuvKQ%3D&reserved=0>

I have an assumption about the cause of the problem. Are the tests running in parallel? In this case `typedefs.test` and `enums-layout.test` are writing to the same object file together, because they both are compiled from the same source.

@zturner Is it possible to specify object file's name in `compile-and-link` mode? Then we can specify different names in different tests for both object files and executables. But I think that splitting the source or combining the tests would be a better idea.

I will fix it only tomorrow, because I'm already at home today. Feel free to revert it if needed.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54942/new/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD54942%2Fnew%2F&data=02%7C01%7Cstilis%40microsoft.com%7C91af7eec00544628293a08d65af2edaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636796396749076680&sdata=IZDR90FOCIsmfggh9InT9n%2FDb1jESMfX1RXiwJdgHMg%3D&reserved=0>

https://reviews.llvm.org/D54942<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD54942&data=02%7C01%7Cstilis%40microsoft.com%7C91af7eec00544628293a08d65af2edaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636796396749076680&sdata=OqLhRdcrQtVav7%2BlfRNCbGZA2xijPr2WYWYQ9v5rFdI%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181205/f3fffa81/attachment-0001.html>