[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz created this revision.
sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, davide, beanz.
Herald added a subscriber: mgorny.

Add features to LLDB CMake builds that have so far only been available in Xcode. Clean up a few inconveniences and prepare further improvements.

Options:

- `LLDB_FRAMEWORK_BUILD_DIR` determines target directory (in build-tree)
- `LLDB_FRAMEWORK_INSTALL_DIR` **only** determines target directory in install-tree
- `LLVM_EXTERNALIZE_DEBUGINFO` allows externalized debug info (dSYM on Darwin, emitted to `bin`)
- `LLDB_FRAMEWORK_TOOLS` determines which executables will be copied to the framework's Resources (dropped symlinking, removed INCLUDE_IN_SUITE, removed dummy targets)

Other changes:

- clean up `add_lldb_executable()`
- include `LLDBFramework.cmake` from `source/API/CMakeLists.txt`
- use `*.plist.in` files, which are typical for CMake and independent from Xcode
- add clang headers to the framework bundle


https://reviews.llvm.org/D55328

Files:
  CMakeLists.txt
  cmake/modules/AddLLDB.cmake
  cmake/modules/LLDBConfig.cmake
  cmake/modules/LLDBFramework.cmake
  resources/LLDB-Info.plist.in
  source/API/CMakeLists.txt
  test/CMakeLists.txt
  tools/argdumper/CMakeLists.txt
  tools/darwin-debug/CMakeLists.txt
  tools/debugserver/CMakeLists.txt
  tools/debugserver/source/CMakeLists.txt
  tools/driver/CMakeLists.txt
  tools/lldb-server/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55328.176828.patch
Type: text/x-patch
Size: 25736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181205/0e5b6cd1/attachment-0001.bin>