[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz updated this revision to Diff 175729.
sgraenitz added a comment.

The default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55012/new/

https://reviews.llvm.org/D55012

Files:
  CMakeLists.txt
  tools/debugserver/CMakeLists.txt


Index: tools/debugserver/CMakeLists.txt
===================================================================
--- tools/debugserver/CMakeLists.txt
+++ tools/debugserver/CMakeLists.txt
@@ -16,9 +16,11 @@
   include_directories(${LLDB_SOURCE_DIR}/include)
 
   option(LLDB_USE_ENTITLEMENTS "When codesigning, use entitlements if available" ON)
+  set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING
+      "Identity for code signing debugserver (Darwin only)")
+
   if(LLDB_CODESIGN_IDENTITY)
-    # In the future we may use LLVM_CODESIGNING_IDENTITY directly.
-    set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY})
+    set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY} CACHE STRING "" FORCE)
   endif()
 endif()
 
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -12,9 +12,11 @@
 include(AddLLDB)
 
 option(LLDB_USE_ENTITLEMENTS "When codesigning, use entitlements if available" ON)
+set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING
+    "Identity for code signing debugserver (Darwin only)")
+
 if(LLDB_CODESIGN_IDENTITY)
-  # In the future we may use LLVM_CODESIGNING_IDENTITY directly.
-  set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY})
+  set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY} CACHE STRING "" FORCE)
 endif()
 
 # Define the LLDB_CONFIGURATION_xxx matching the build type


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55012.175729.patch
Type: text/x-patch
Size: 1403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181128/0f1c2a17/attachment.bin>