[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Wed Nov 28 01:03:03 PST 2018

aleksandr.urakov added a comment.

Thanks all!

In D54942#1310224 <https://reviews.llvm.org/D54942#1310224>, @zturner wrote:

> Makes sense.  Just curious, is the order file strictly necessary for this test?  `/Gy` is the same as `-ffunction-sections`, so there could be an argument to be made for exposing `--function-sections` on the command line of `build.py`.  On the other hand, there's no harm in falling back to the old mechanism here since this test isn't intended to be portable.

Yes, the order is necessary for the test, because it tests exactly correct processing of source files that are not continuous in the result binary. But I'm not against leaving it as is.

> Ahh, right.  I wonder if we should have something like `--arch=lldb` that means "match the architecture of LLDB".  It's not urgent for this patch, but it could be useful as a followup.

Yes, I thought about a solution like these too. May be we could even make it the default `arch`?

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54942/new/

https://reviews.llvm.org/D54942